AXIS2-6082 fix reproducible builds issues #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortlepp
approved these changes
Mar 18, 2025
Member
cortlepp
left a comment
cortlepp
left a comment
There was a problem hiding this comment.
Some of the maintainers with more experience should weigh in on whether we rely on these timestamps elsewhere, but otherwise LGTM (and thanks for the PR!).
cortlepp
approved these changes
Mar 19, 2025
Contributor
|
Looks good - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested by running classical
mvn installfollowed bymvn clean package artifact:compareprecisely the full command used is
mvn -Papache-release clean install -DskipTests -Dmaven.javadoc.skip -Dgpg.skip && mvn -Papache-release clean package -DskipTests -Dmaven.javadoc.skip -Dgpg.skip artifact:comparefixed the 2 root causes:
with this PR merged, I hope that third-party rebuild will be ok for 2.0.1 https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/axis2/README.md